Skip to content

telemetry(AmazonQ): Adding amazonq_feedback event for feedback #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 5, 2025
Merged

telemetry(AmazonQ): Adding amazonq_feedback event for feedback #969

merged 5 commits into from
Feb 5, 2025

Conversation

@laileni-aws
Copy link
Contributor

@laileni-aws laileni-aws commented Jan 30, 2025 •
edited
Loading

Problem

  • Missing generic feedback event for AmazonQ.

Solution

  • Added genericamazonq_feedback event for feedback for different features.
 {
            "name": "amazonq_feedback",
            "description": "When a user gives feedback using vote or comment or rating in the conversation",
            "metadata": [
                {
                    "type": "amazonqConversationId",
                    "required": false
                },
                {
                    "type": "credentialStartUrl",
                    "required": false
                },
                {
                    "type": "featureId"
                },
                {
                    "type": "interactionType",
                    "required": false
                }
            ]
        },
  • featureId can be amazonQTest/amazonQReview or any amazonQ Feature.
  • interactionType can be upvote/downvote or comment or rating.
  • This event can be expanded by adding additional fields like comment, rating according to the requirement.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laileni-aws laileni-aws marked this pull request as ready for review January 30, 2025 23:43
@laileni-aws laileni-aws requested a review from a team as a code owner January 30, 2025 23:43
justinmk3
justinmk3 reviewed Jan 31, 2025
View reviewed changes
@laileni-aws laileni-aws requested a review from justinmk3 January 31, 2025 16:50
justinmk3
justinmk3 reviewed Feb 3, 2025
View reviewed changes
justinmk3
justinmk3 reviewed Feb 3, 2025
View reviewed changes
telemetry/definitions/commonDefinitions.json Outdated
{
"name": "interactionType",
"type": "string",
"description": "User can click on thumbs up / down or comment or give rating to share feedback.",
Copy link
Contributor

@justinmk3 justinmk3 Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "User can click on thumbs up / down or comment or give rating to share feedback.",
"description": "User interaction, especially for AI-related features.",

@laileni-aws laileni-aws requested a review from justinmk3 February 3, 2025 21:18
justinmk3
justinmk3 reviewed Feb 5, 2025
View reviewed changes
dhruvigajjar
dhruvigajjar reviewed Feb 5, 2025
View reviewed changes
telemetry/definitions/commonDefinitions.json
]
},
{
"name": "amazonq_approachThumbsDown",
Copy link
Contributor

@dhruvigajjar dhruvigajjar Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this metric is used by multiple IDEs. did you check if it's no longer in use? If not then it will break their code.

Copy link
Contributor Author

@laileni-aws laileni-aws Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, confirmed with @jpinkney-aws , this is not being used by any team in both IDE's.

dhruvigajjar
dhruvigajjar reviewed Feb 5, 2025
View reviewed changes
@justinmk3 justinmk3 merged commit 9fc0c58 into aws:main Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvigajjar dhruvigajjar Awaiting requested review from dhruvigajjar

1 more reviewer

@justinmk3 justinmk3 justinmk3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laileni-aws @dhruvigajjar @justinmk3